Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tool_mode parameter to MessageTextInput in ID Generator Component #5311

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

Vigtu
Copy link
Contributor

@Vigtu Vigtu commented Dec 17, 2024

Pull Request Description

Summary

This pull request introduces an enhancement to the IDGeneratorComponent by adding a new parameter, tool_mode, to the MessageTextInput. This improvement allows the component to be utilized in a more versatile manner, enhancing its functionality within the application.

Changes Made

  • Added the tool_mode=True parameter to the MessageTextInput in the inputs list of the IDGeneratorComponent.

Motivation

The addition of the tool_mode parameter provides greater flexibility and usability for the IDGeneratorComponent. It allows the component to be used in various contexts, improving the overall user experience.

Test Template:
image
ID Generator Component.json

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Dec 17, 2024
@Vigtu Vigtu changed the title feat: add tool_mode parameter to MessageTextInput feat: add tool_mode parameter to MessageTextInput in ID Generator Component Dec 17, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 17, 2024
@ogabrielluiz ogabrielluiz force-pushed the id-generator-component branch from b35af54 to 69fec56 Compare December 17, 2024 17:30
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) December 17, 2024 17:30
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 17, 2024
@ogabrielluiz ogabrielluiz force-pushed the id-generator-component branch from 69fec56 to 6226f4e Compare December 18, 2024 01:34
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@ogabrielluiz ogabrielluiz force-pushed the id-generator-component branch from 6226f4e to 4b35cce Compare December 18, 2024 01:59
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@ogabrielluiz ogabrielluiz force-pushed the id-generator-component branch from 4b35cce to 04a6c14 Compare December 18, 2024 14:35
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
Vigtu and others added 2 commits December 18, 2024 11:46
…se handling

- Adjusted test to wait for the "Toolset" element to appear before asserting its count.
- Modified code handling to replace "tool_mode=True" with "tool_mode=False" and verified the updated code is different.
- Added response check for the custom component to ensure a successful status (200) after submission.
@ogabrielluiz ogabrielluiz force-pushed the id-generator-component branch from ceb1a21 to df0a623 Compare December 18, 2024 14:46
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Dec 18, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into langflow-ai:main with commit e79b164 Dec 18, 2024
34 checks passed
anovazzi1 pushed a commit that referenced this pull request Dec 19, 2024
…ponent (#5311)

* feat: add tool_mode parameter to MessageTextInput for enhanced functionality

* fix: update tool mode test to ensure correct functionality and response handling

- Adjusted test to wait for the "Toolset" element to appear before asserting its count.
- Modified code handling to replace "tool_mode=True" with "tool_mode=False" and verified the updated code is different.
- Added response check for the custom component to ensure a successful status (200) after submission.

---------

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants