Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend mongodb component with mTLS #4591

Merged
merged 14 commits into from
Nov 19, 2024

Conversation

PythonbergIT
Copy link
Contributor

One can use a client certificate with private key to have a secure connection to mongodb atlas system. The old way without certificate is still working.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #4591 will degrade performances by 21.54%

Comparing PythonbergIT:main (1ad1dc3) with main (2cf3881)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main PythonbergIT:main Change
test_successful_run_with_input_type_text 206.9 ms 144.4 ms +43.25%
test_successful_run_with_output_type_debug 161.2 ms 205.4 ms -21.54%

@ogabrielluiz ogabrielluiz changed the title Extend mongodb component with mTLS feat: Extend mongodb component with mTLS Nov 14, 2024
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Nov 14, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @PythonbergIT

thanks for this

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 16, 2024
@ogabrielluiz ogabrielluiz merged commit 67a9fff into langflow-ai:main Nov 19, 2024
27 checks passed
mieslep pushed a commit to mieslep/langflow that referenced this pull request Nov 22, 2024
* Extend mongodb component with mTLS

* [autofix.ci] apply automated fixes

* fix check style errors

* [autofix.ci] apply automated fixes

* bug fix

* Update src/backend/base/langflow/components/vectorstores/mongodb_atlas.py

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>

* adjustment for MyPy

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Thorsten Philipp <thorsten.philipp@msg.group>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
diogocabral pushed a commit to headlinevc/langflow that referenced this pull request Nov 26, 2024
* Extend mongodb component with mTLS

* [autofix.ci] apply automated fixes

* fix check style errors

* [autofix.ci] apply automated fixes

* bug fix

* Update src/backend/base/langflow/components/vectorstores/mongodb_atlas.py

Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>

* adjustment for MyPy

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Thorsten Philipp <thorsten.philipp@msg.group>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Gabriel Luiz Freitas Almeida <gabriel@langflow.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants