Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to laminas-servicemanager:4.0 #51

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Mar 4, 2024

This patch is a BC break because AssertionManager inheritance has changed to AbstractSingleInstancePluginManager

Closes #50

Signed-off-by: George Steel <george@net-glue.co.uk>
@gsteel gsteel added this to the 3.0.0 milestone Mar 4, 2024
@gsteel gsteel changed the base branch from 2.17.x to 3.0.x March 4, 2024 15:46
@gsteel gsteel requested a review from a team March 7, 2024 13:56
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is it worth keeping ^3 support around, for a period of time? EDIT: seen target branch - nope :)

@gsteel gsteel self-assigned this Mar 8, 2024
@gsteel gsteel merged commit fd0397b into laminas:3.0.x Mar 8, 2024
12 checks passed
@gsteel gsteel deleted the upgrade-service-manager branch March 8, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants