Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[advice] Use json to store g:nerdfont#path#{extension|pattern|basename}#defaults #14

Closed
Freed-Wu opened this issue Oct 21, 2022 · 0 comments
Closed

[advice] Use json to store g:nerdfont#path#{extension|pattern|basename}#defaults #14

Freed-Wu opened this issue Oct 21, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Freed-Wu
Copy link
Collaborator

Freed-Wu commented Oct 21, 2022 •
edited
Loading

  1. It is easier to edit even for those contributors is not familiar with vim script
  2. It is easier to compare the difference between this project's icon and other projects which provide icon display, so we can add icons more easily.
  3. It is easier to sort json by jq

Just my 2c, TIA!
@lambdalisue lambdalisue added enhancement New feature or request good first issue Good for newcomers labels Oct 22, 2022
lambdalisue added a commit that referenced this issue Oct 22, 2022
@lambdalisue
Merge pull request #15 from Freed-Wu/json
a82c9b7 
Fix #14, use json to store icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lambdalisue @Freed-Wu