feat(l1): batch account updates in full sync #2088
Draft
+643
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this version does not take into account byzantine nodes
mpaulucci
reviewed
Feb 26, 2025
| @@ -48,7 +48,11 @@ impl Blockchain { | |||
| } | |||
| } | |||
|
|
|||
| pub fn add_block(&self, block: &Block) -> Result<(), ChainError> { | |||
| pub fn add_block( | |||
There was a problem hiding this comment.
I was thinking something in the lines of adding add_blocks, which only commits the trie once.
Then you can trivially add
fn add_block(block) { add_blocks(vec![block])}
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Full syncing in holesky
Description
Batches account updates which was identified as the main bottleneck when syncing in full mode. Now, instead of applying the updates on every block, we do it only for the last one in the batch, which is currently every 128 blocks because of the request limit.
Closes None