feat(l1, l2): show rich wallets on startup #2045
Conversation
|
tomip01
changed the title
cmd/ethrex/ethrex.rs
Outdated
| let l2_pks = include_str!("../../test_data/private_keys.txt"); | ||
| show_rich_accounts(&genesis, l2_pks); |
There was a problem hiding this comment.
I use this so we can run the print independent where we execute it
There was a problem hiding this comment.
Hi Tomi, quick question. Doesn't that mean that if you change the .txt you have to recompile the program?
There was a problem hiding this comment.
Yes, that's correct. This file is for testing purposes. it's expected to be recompiled
cmd/ethrex/ethrex.rs
Outdated
| let Ok(pk_h256) = pk_str.parse::<H256>() else { | ||
| return; | ||
| }; |
There was a problem hiding this comment.
If there is any error, don't print the addresses so we don't stop the ethrex client
cmd/ethrex/ethrex.rs
Outdated
| @@ -497,3 +508,52 @@ fn read_known_peers(file_path: PathBuf) -> Result<Vec<Node>, serde_json::Error> | |||
|
|
|||
| serde_json::from_reader(file) | |||
| } | |||
|
|
|||
| fn show_rich_accounts(genesis: &Genesis, contents: &str) { | |||
There was a problem hiding this comment.
If this is only for --dev, can we move this to the dev crate? We're polluting this file with all kinds of random stuff.
There was a problem hiding this comment.
Yes, this should be in the dev crate.
There was a problem hiding this comment.
Thanks for pointing it out, changed here 37e2093
cmd/ethrex/ethrex.rs
Outdated
| let l2_pks = include_str!("../../test_data/private_keys.txt"); | ||
| show_rich_accounts(&genesis, l2_pks); |
There was a problem hiding this comment.
Hi Tomi, quick question. Doesn't that mean that if you change the .txt you have to recompile the program?
Motivation
In this PR we show the top 10 rich accounts on startup.
Description
When Genesis file is read, sort the accounts initialized by their balance and print the top 10. We show their private keys by calculating the address from it.
The print of the addresses set in the genesis block is show this way:
Closes #1981