Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying Python executable path in nbstripout --install #181

Closed
nobodyinperson opened this issue Jan 17, 2023 · 0 comments · Fixed by #182
Closed

Specifying Python executable path in nbstripout --install #181

nobodyinperson opened this issue Jan 17, 2023 · 0 comments · Fixed by #182
Assignees
@nobodyinperson
Labels
state:pr pending This issue has a pending pull request type:enhancement
Milestone
0.6.2

Comments

@nobodyinperson
Copy link
Contributor

It would be helpful if there was a way to specify the path nbstripout --install puts into e.g. .git/config. This would enable to specify only python or python3, not the full path, which can differ between runtimes, e.g. when using Apptainer/Singularity or Docker containers (/usr/bin/python vs /usr/local/bin/python) occasionally as well as the native Python on the same repo.
nobodyinperson added a commit to nobodyinperson/nbstripout that referenced this issue Jan 17, 2023
@nobodyinperson
Add --python option to --install (kynan#181)
91ca3c9 
Useful to specify e.g. `nbstripout --install --python python3` so not
the full path to Python but a more cross-native/container value is put
into the git config.

closes kynan#181
@nobodyinperson nobodyinperson mentioned this issue Jan 17, 2023
Merged
@kynan kynan added type:enhancement state:pr pending This issue has a pending pull request labels Jan 22, 2023
@kynan kynan added this to the 0.7.0 milestone Jan 22, 2023
kynan added a commit that referenced this issue Jan 24, 2023
@nobodyinperson @kynan
Add --python option to --install (#181) (#182)
e4c5b4d 
Useful to specify e.g. `nbstripout --install --python python3` so not
the full path to Python but a more cross-native/container value is put
into the git config.

closes #181

* 📝 Document --python in README
* ✅ Add test for --python
* 📝 Fix code snippets quoting in README
* 📝 Improve wording for --python in README
* 🎨 Fix code style in new --python test

Co-authored-by: Florian Rathgeber <florian.rathgeber@gmail.com>
@kynan kynan modified the milestones: 0.7.0, 0.6.2 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nobodyinperson nobodyinperson

Labels
state:pr pending This issue has a pending pull request type:enhancement
Projects
None yet
Milestone
0.6.2
Development

Successfully merging a pull request may close this issue.

Add --python option to --install (#181) nobodyinperson/nbstripout
2 participants
@kynan @nobodyinperson