refactor: Remove custom multierror #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/M
nesmabadr
approved these changes
Oct 10, 2023
nesmabadr
approved these changes
Oct 10, 2023
kyma-bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
* cleanup serverless chart config (#1798) * test: CLI E2E tests with template operator (#1792) * Setup e2e tests action * Forcing an empty commit. * Add go file + make target * add Run E2E tests step * add e2e test * refactor existing E2E tests * remove redundant step in e2e yaml * trigger the pipeline * editing go file to trigger pipeline * fix yaml file * remove unneeded expect statement * some fixes * some fixes * add suite_test.go * ginkgo bootstrap * add e2e_suite_test * remove unnecessary log * fixes * fixes * start test implementation * disable running e2e from * create module test changes * exclude e2e from test target * kyma alpha deploy * fix * Forcing an empty commit. * fix * fix * fix * fix * fix * fix * fix * Increase timeout * fix * fix * fix * fixes * fixes * fix * Reduce timeout * fixes * fixes * fixes * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * enable module * enable module * stop running create module command for the rest of the e2e * stop running create module command for the rest of the e2e * debug * validate resources after enablement * fix linting * debugging * debugging * debugging * debugging * fixes * fixes * uncomment and add module name * print kyma.status.modules * add v1extensions scheme * increase timeout * debugging * debugging * revert module creation test * fix linting * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * disable module * add new template-operator * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix linting * remove unneeded env variables * remove unneeded env variables * debug error * debug error * debug error * fixes * Oleksandr's comments * fix test * remove * fix test * fix test * comment 1 * Oleksandr's PR comments * fix * fix * fix * fix * Rephrase the Describe * Oleksandr's comments * Xin's comments * Oleksandr's comments * flatten * fix linting * fixes * fixes * fixes * fix create module * remove duplicate targets * Forcing an empty commit. * Xin's comment * Xin's comment * fix status * fix status * fix status * fix status * comment * remove unneeded consts * fix: Error out if create module is executed with an existing version without the overwrite flag (#1797) * Setup e2e tests action * Forcing an empty commit. * Add go file + make target * add Run E2E tests step * add e2e test * refactor existing E2E tests * remove redundant step in e2e yaml * trigger the pipeline * editing go file to trigger pipeline * fix yaml file * remove unneeded expect statement * some fixes * some fixes * add suite_test.go * ginkgo bootstrap * add e2e_suite_test * remove unnecessary log * fixes * fixes * start test implementation * disable running e2e from * create module test changes * exclude e2e from test target * kyma alpha deploy * fix * Forcing an empty commit. * fix * fix * fix * fix * fix * fix * fix * Increase timeout * fix * fix * fix * fixes * fixes * fix * Reduce timeout * fixes * fixes * fixes * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * enable module * enable module * stop running create module command for the rest of the e2e * stop running create module command for the rest of the e2e * debug * validate resources after enablement * fix linting * debugging * debugging * debugging * debugging * fixes * fixes * uncomment and add module name * print kyma.status.modules * add v1extensions scheme * increase timeout * debugging * debugging * revert module creation test * fix linting * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * disable module * add new template-operator * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix linting * remove unneeded env variables * remove unneeded env variables * debug error * debug error * debug error * fixes * Oleksandr's comments * fix test * remove * fix test * fix test * comment 1 * Oleksandr's PR comments * fix * fix * fix * fix * fix implementation * Add e2e test * fix test * fix * fix * debug test * fix linting * debuggging * Rephrase the Describe * Oleksandr's comments * debug test * debug test * debug test * fix target * fix error message * fix: Add module version annotation to the ModuleTemplate (#1799) * add test * Addressing test comment * PR comments * enhance message (#1801) * feat: Add refactor title type (#1803) * remove custom multierror. use join on one fix occurence (#1802) * chore: Fix some CLI checkmarx issues (#1807) * Add some error handling * More error handling for regex * Condest reconciler call * Add default status * bump golang.org/x/net (#1815) * fix(checkmarx): Fix unhandled errors (#1813) * Fix unhandled errors * APlly review comments * fix misspelling * update kyma to 2.19.2 --------- Co-authored-by: Damian Badura <45110612+dbadura@users.noreply.github.com> Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: Benjamin Lindner <50365642+lindnerby@users.noreply.github.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>
kyma-bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* cleanup serverless chart config (#1798) * test: CLI E2E tests with template operator (#1792) * Setup e2e tests action * Forcing an empty commit. * Add go file + make target * add Run E2E tests step * add e2e test * refactor existing E2E tests * remove redundant step in e2e yaml * trigger the pipeline * editing go file to trigger pipeline * fix yaml file * remove unneeded expect statement * some fixes * some fixes * add suite_test.go * ginkgo bootstrap * add e2e_suite_test * remove unnecessary log * fixes * fixes * start test implementation * disable running e2e from * create module test changes * exclude e2e from test target * kyma alpha deploy * fix * Forcing an empty commit. * fix * fix * fix * fix * fix * fix * fix * Increase timeout * fix * fix * fix * fixes * fixes * fix * Reduce timeout * fixes * fixes * fixes * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * enable module * enable module * stop running create module command for the rest of the e2e * stop running create module command for the rest of the e2e * debug * validate resources after enablement * fix linting * debugging * debugging * debugging * debugging * fixes * fixes * uncomment and add module name * print kyma.status.modules * add v1extensions scheme * increase timeout * debugging * debugging * revert module creation test * fix linting * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * disable module * add new template-operator * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix linting * remove unneeded env variables * remove unneeded env variables * debug error * debug error * debug error * fixes * Oleksandr's comments * fix test * remove * fix test * fix test * comment 1 * Oleksandr's PR comments * fix * fix * fix * fix * Rephrase the Describe * Oleksandr's comments * Xin's comments * Oleksandr's comments * flatten * fix linting * fixes * fixes * fixes * fix create module * remove duplicate targets * Forcing an empty commit. * Xin's comment * Xin's comment * fix status * fix status * fix status * fix status * comment * remove unneeded consts * fix: Error out if create module is executed with an existing version without the overwrite flag (#1797) * Setup e2e tests action * Forcing an empty commit. * Add go file + make target * add Run E2E tests step * add e2e test * refactor existing E2E tests * remove redundant step in e2e yaml * trigger the pipeline * editing go file to trigger pipeline * fix yaml file * remove unneeded expect statement * some fixes * some fixes * add suite_test.go * ginkgo bootstrap * add e2e_suite_test * remove unnecessary log * fixes * fixes * start test implementation * disable running e2e from * create module test changes * exclude e2e from test target * kyma alpha deploy * fix * Forcing an empty commit. * fix * fix * fix * fix * fix * fix * fix * Increase timeout * fix * fix * fix * fixes * fixes * fix * Reduce timeout * fixes * fixes * fixes * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * debug error * enable module * enable module * stop running create module command for the rest of the e2e * stop running create module command for the rest of the e2e * debug * validate resources after enablement * fix linting * debugging * debugging * debugging * debugging * fixes * fixes * uncomment and add module name * print kyma.status.modules * add v1extensions scheme * increase timeout * debugging * debugging * revert module creation test * fix linting * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix test * disable module * add new template-operator * fix test * fix test * fix test * fix test * fix test * fix test * fix test * fix linting * remove unneeded env variables * remove unneeded env variables * debug error * debug error * debug error * fixes * Oleksandr's comments * fix test * remove * fix test * fix test * comment 1 * Oleksandr's PR comments * fix * fix * fix * fix * fix implementation * Add e2e test * fix test * fix * fix * debug test * fix linting * debuggging * Rephrase the Describe * Oleksandr's comments * debug test * debug test * debug test * fix target * fix error message * fix: Add module version annotation to the ModuleTemplate (#1799) * add test * Addressing test comment * PR comments * enhance message (#1801) * feat: Add refactor title type (#1803) * remove custom multierror. use join on one fix occurence (#1802) * chore: Fix some CLI checkmarx issues (#1807) * Add some error handling * More error handling for regex * Condest reconciler call * Add default status * bump golang.org/x/net (#1815) * fix(checkmarx): Fix unhandled errors (#1813) * Fix unhandled errors * APlly review comments * fix misspelling * update kyma to 2.19.3 --------- Co-authored-by: Damian Badura <45110612+dbadura@users.noreply.github.com> Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: Benjamin Lindner <50365642+lindnerby@users.noreply.github.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)