upgrade go mod and smoke test for alpha deploy #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ruanxin
commented
Sep 1, 2023
•
ruanxin
commented
- upgraded dependencies to use latest lifecycle-manager, hydroform
- upgraded kustomize
- regular upgrade to latest k8s.io
- add smoke test for alpha deploy command
update go mod
# Conflicts: # go.mod # go.sum
kyma-bot
added
the
size/XL
ruanxin
changed the title
ruanxin
added
do-not-merge/hold
internal/deploy/bootstrap.go
Outdated
| @@ -70,6 +71,7 @@ func Bootstrap( | |||
| if err != nil { | |||
| return false, err | |||
| } | |||
| manifestObjs = filterCRD(manifestObjs) | |||
There was a problem hiding this comment.
filter functions are usually used to return a subset of some collection. Here we're modifying objects. Perhaps fixTimestamps or something similar is a better choice.
Tomasz-Smelcerz-SAP
approved these changes
Sep 6, 2023
kyma-bot
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Release 2.18.0 (#1759) * upgrade go mod and smoke test for alpha deploy (#1758) * revert go mod upgarde * add smoke test update go mod * enhance github pipeline * fix breaking changes * set creationtimestamp for crd * fix smoke test * rename * remove unused env * Allow create module for no git directory (#1751) * pre-ready commit * pre-ready commit 2 #1723 * pre-ready PR #1723 * Add localfsblob instead of github metadata #1723 * Remove the fileSystem impl and OCM SourceMeta when it's not a git target folder #1723 * Remove pointer receiver for the 'GitSource' struct as the methods are not updating the struct #1723 * chancges after PR comments * Improved the codebase and adding in consideration the new requirement related to the security scan. * fix linting newline * Add Unit tests to "files.SearchForTargetDirByName" function * Add support to interactive mode * Revert Sec Scan struct * Add a yellow warning when the target folder's not a git repo * Add missed sec config path file check * Add support of the relative and absolute path * Changed 'isFileExist' to boolean instead of returning error * Update message * redecalred the err * remove err.Err() when sec scan's skipped * NewNice should init with NonInteractive * refactor determineRepositoryURL * make new line for Caution message --------- Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Introduce flag to pass git remote (#1762) * Introduce new flag to configure remote name of git repo * make docs * unit test * Merge with main * Unexport function * feat: Add Custom State Check Support to Create Module Command (#1764) * feat: Add Custom State Check Support to Create Module Command * custom_state_check_test.go: Add Unit Tests * Commit TWS suggestions --------- Co-authored-by: jeremyharisch <jeremy@harisch.de> * fix: Remove CustomStateCheck flags from the Module Command (#1767) * fix: Remove CustomStateCheck flags from the Module Command * add help desc * gen docs * Extend tests with correct scenarios * add check for required customStateChecks to validation * bump and fix lint --------- Co-authored-by: Benjamin Lindner <benjamin.lindner@sap.com> * Fix repoUrl for parent-child git structure (#1770) * fix bug * Add unit test * remove test * revert changes * Revert "revert changes" This reverts commit 150cb24. * fix path * fix linting * CR comments * Revert "CR comments" This reverts commit 4f636c1. * CR comments * Forcing an empty commit. * remove unneeded if condition * Do not remove `.git` if exists (#1775) * Do not remove .git if exists * Add one testcase * use ociblob instead of ocilocalblob for oci v2 (#1768) * remove compatible attribute for v2, so that v2 generate resources with ociblob instead of depricated ocilocalblob * add e2e test * add e2e test * add module config test * add module config test * fix github action * extend e2e test drop gotest.tools * fix lint * test repoURL * fix TEST_REPOSITORY_URL location * gofmt * align name * gomod(deps): bump github.com/containerd/containerd from 1.7.3 to 1.7.6 (#1774) Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.3 to 1.7.6. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.3...v1.7.6) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bring back default kyma version to main for main branch (#1778) * change default kyma to 2.18.0 * update docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jeremy Harisch <48282931+jeremyharisch@users.noreply.github.com> Co-authored-by: Mohammed Mesaoudi <mohammed.mesaoudi@sap.com> Co-authored-by: Hukumraj Singh Deora <54686422+LeelaChacha@users.noreply.github.com> Co-authored-by: jeremyharisch <jeremy@harisch.de> Co-authored-by: Benjamin Lindner <benjamin.lindner@sap.com> Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kyma-bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Release 2.18.0 (#1759) * upgrade go mod and smoke test for alpha deploy (#1758) * revert go mod upgarde * add smoke test update go mod * enhance github pipeline * fix breaking changes * set creationtimestamp for crd * fix smoke test * rename * remove unused env * Allow create module for no git directory (#1751) * pre-ready commit * pre-ready commit 2 #1723 * pre-ready PR #1723 * Add localfsblob instead of github metadata #1723 * Remove the fileSystem impl and OCM SourceMeta when it's not a git target folder #1723 * Remove pointer receiver for the 'GitSource' struct as the methods are not updating the struct #1723 * chancges after PR comments * Improved the codebase and adding in consideration the new requirement related to the security scan. * fix linting newline * Add Unit tests to "files.SearchForTargetDirByName" function * Add support to interactive mode * Revert Sec Scan struct * Add a yellow warning when the target folder's not a git repo * Add missed sec config path file check * Add support of the relative and absolute path * Changed 'isFileExist' to boolean instead of returning error * Update message * redecalred the err * remove err.Err() when sec scan's skipped * NewNice should init with NonInteractive * refactor determineRepositoryURL * make new line for Caution message --------- Co-authored-by: Xin Ruan <xin.ruan@sap.com> * Introduce flag to pass git remote (#1762) * Introduce new flag to configure remote name of git repo * make docs * unit test * Merge with main * Unexport function * feat: Add Custom State Check Support to Create Module Command (#1764) * feat: Add Custom State Check Support to Create Module Command * custom_state_check_test.go: Add Unit Tests * Commit TWS suggestions --------- Co-authored-by: jeremyharisch <jeremy@harisch.de> * fix: Remove CustomStateCheck flags from the Module Command (#1767) * fix: Remove CustomStateCheck flags from the Module Command * add help desc * gen docs * Extend tests with correct scenarios * add check for required customStateChecks to validation * bump and fix lint --------- Co-authored-by: Benjamin Lindner <benjamin.lindner@sap.com> * Fix repoUrl for parent-child git structure (#1770) * fix bug * Add unit test * remove test * revert changes * Revert "revert changes" This reverts commit 150cb24. * fix path * fix linting * CR comments * Revert "CR comments" This reverts commit 4f636c1. * CR comments * Forcing an empty commit. * remove unneeded if condition * Do not remove `.git` if exists (#1775) * Do not remove .git if exists * Add one testcase * use ociblob instead of ocilocalblob for oci v2 (#1768) * remove compatible attribute for v2, so that v2 generate resources with ociblob instead of depricated ocilocalblob * add e2e test * add e2e test * add module config test * add module config test * fix github action * extend e2e test drop gotest.tools * fix lint * test repoURL * fix TEST_REPOSITORY_URL location * gofmt * align name * gomod(deps): bump github.com/containerd/containerd from 1.7.3 to 1.7.6 (#1774) Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.3 to 1.7.6. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.3...v1.7.6) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bring back default kyma version to main for main branch (#1778) * chore(infra): Adjust GitHub Action linters (#1780) * Configure PR Title linter to impose Conventional Commits spec * Configure dependabot to adhere to the Conventional Commits spec * Configure markdown files links checker * Configure changelog groups for the goreleaser * Updating the security scan labels according to the new fields in the security config files (#1776) * fixes * Add security scan labels to e2e test * fix test * fix test * debug test * debug test * fix test * debug test * debug test * debug test * debug test * debug test * debug test * debug test * debug test * debug test * debug test * debug test * fix test * debug test * overwrite version * overwrite version * overwrite version * debug test * remove debugging statements * fix * gomod(deps): bump github.com/cyphar/filepath-securejoin (#1772) Bumps [github.com/cyphar/filepath-securejoin](https://github.com/cyphar/filepath-securejoin) from 0.2.3 to 0.2.4. - [Release notes](https://github.com/cyphar/filepath-securejoin/releases) - [Commits](cyphar/filepath-securejoin@v0.2.3...v0.2.4) --- updated-dependencies: - dependency-name: github.com/cyphar/filepath-securejoin dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Run GH ACtion also on release branches (#1785) * deps: Update reconciler version (#1786) * Update reconciler version with Ory reconciler changes for Hydra migration * fix go.sum --------- Co-authored-by: Badr, Nesma <nesma.badr@sap.com> * chore(dependabot): bump github.com/go-git/go-git/v5 from 5.7.0 to 5.9.0 (#1783) Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.7.0 to 5.9.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.7.0...v5.9.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(dependabot): bump istio.io/client-go (#1788) Bumps [istio.io/client-go](https://github.com/istio/client-go) from 1.19.0-alpha.1.0.20230825174843-7a8fbe28cb5d to 1.19.0. - [Commits](https://github.com/istio/client-go/commits/1.19.0) --- updated-dependencies: - dependency-name: istio.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Xin Ruan <xin.ruan@sap.com> Co-authored-by: Mohammed Mesaoudi <mohammed.mesaoudi@sap.com> Co-authored-by: Hukumraj Singh Deora <54686422+LeelaChacha@users.noreply.github.com> Co-authored-by: Benjamin Lindner <benjamin.lindner@sap.com> Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Oleksandr Meteiko <ameteiko@users.noreply.github.com> Co-authored-by: Tim Riffer <tim.riffer@sap.com> Co-authored-by: Badr, Nesma <nesma.badr@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.