kyma alpha create module using config file #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/XL
Tomasz-Smelcerz-SAP
force-pushed
the
feature/create-module-from-file
branch
from
d5de549 to
925c20a
Compare
Tomasz-Smelcerz-SAP
force-pushed
the
feature/create-module-from-file
branch
from
0626dc7 to
677ce5f
Compare
mmitoraj
reviewed
Jul 5, 2023
mmitoraj
reviewed
Jul 5, 2023
Tomasz-Smelcerz-SAP
requested review from
NHingerl,
grego952,
IwonaLanger,
nataliasitko and
a team
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
ruanxin
reviewed
Jul 7, 2023
| return fmt.Errorf("%w, module name length cannot exceed 255 characters", ErrNameValidation) | ||
| } | ||
| matched, _ := regexp.MatchString(moduleNamePattern, cv.config.Name) | ||
| if !matched { |
There was a problem hiding this comment.
Please give a valid example of the module name here, it's not easy to understand based on the regex, e.g: kyma-project.io/module-name
ruanxin
reviewed
Jul 7, 2023
| return nil, nil, err | ||
| } | ||
|
|
||
| defaultCRPath, err := resolveFilePath(moduleConfig.DefaultCRPath, cmd.opts.Path) |
There was a problem hiding this comment.
This DefaultCRPath should be optional, right? I got error without offer default CR path
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
ruanxin
reviewed
Jul 14, 2023
5 tasks
|
I have tested the |
medmes
previously approved these changes
Jul 24, 2023
mmitoraj
reviewed
Jul 25, 2023
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
medmes
previously approved these changes
Jul 25, 2023
mmitoraj
previously approved these changes
Jul 25, 2023
Tomasz-Smelcerz-SAP
dismissed stale reviews from mmitoraj and medmes
via
0ae9600
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
mmitoraj
approved these changes
Jul 26, 2023
medmes
approved these changes
Jul 26, 2023
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR delivers simplified syntax for
kyma alpha create modulefor non-kubebuilder projects.The syntax for kubebuilder projects stays the same for now.
See #1684 for details
Changes proposed in this pull request:
Related issue(s)
See also #1684