Control in-kcp-mode flag using target flag #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/XXL
kyma-bot
added
the
do-not-merge/work-in-progress
kyma-bot
removed
the
do-not-merge/work-in-progress
lindnerby
requested changes
May 16, 2023
Merged
lindnerby
requested changes
May 16, 2023
lindnerby
requested changes
May 17, 2023
lindnerby
approved these changes
May 17, 2023
kyma-bot
pushed a commit
that referenced
this pull request
May 24, 2023
* remove module template managed-by (#1657) * Control in-kcp-mode flag using target flag (#1663) * Control in-kcp-mode flag using target flag + add unit test * remove mapstructure.Decode and use Deployment structure * fix naming * Check if target is remote * change condition + PatchDeploymentWithInKcpModeFlag * refactor applyManifests * fix linting * PR comments * fix condition * PR comments * Make v1beta2 default (#1666) * Replace references from v1beta1 to v1beta2 * Extend Kyma bootrap with setting sync label depending on kcp-mode * Use kcp mode value for bootstrap * bump hydroform image (#1660) * Arm compiler (#1665) * add Makefile command to compile on Apple Silicon * add darwin-arm build instruction to global build * reorder targets and add comments * updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: indirect * Release 2.14.1 --------- Co-authored-by: Benjamin Lindner <50365642+lindnerby@users.noreply.github.com> Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: Marcin Dobrochowski <39153236+anoipm@users.noreply.github.com> Co-authored-by: Amritanshu Sikdar <amritanshu.sikdar@sap.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kyma-bot
pushed a commit
that referenced
this pull request
May 30, 2023
* remove module template managed-by (#1657) * Control in-kcp-mode flag using target flag (#1663) * Control in-kcp-mode flag using target flag + add unit test * remove mapstructure.Decode and use Deployment structure * fix naming * Check if target is remote * change condition + PatchDeploymentWithInKcpModeFlag * refactor applyManifests * fix linting * PR comments * fix condition * PR comments * Make v1beta2 default (#1666) * Replace references from v1beta1 to v1beta2 * Extend Kyma bootrap with setting sync label depending on kcp-mode * Use kcp mode value for bootstrap * bump hydroform image (#1660) * Arm compiler (#1665) * add Makefile command to compile on Apple Silicon * add darwin-arm build instruction to global build * reorder targets and add comments * updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: indirect * Release 2.14.3 --------- Co-authored-by: Nesma Badr <nesmabadr@aucegypt.edu> Co-authored-by: Marcin Dobrochowski <39153236+anoipm@users.noreply.github.com> Co-authored-by: Amritanshu Sikdar <amritanshu.sikdar@sap.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
--in-kcp-modeduring LM deployment iftargetpassed toKyma alpha deployis set toremoteRelated issue(s)
Resolves kyma-project/lifecycle-manager#575