Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value for istio specifying k3d as deployment #1383

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Add value for istio specifying k3d as deployment #1383

merged 8 commits into from
Sep 26, 2022

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Sep 21, 2022

Description

Changes proposed in this pull request:

  • Add k3d parameter used when deploying Kyma on k3d

Related issues

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2022
@barchw barchw mentioned this pull request Sep 21, 2022
Closed
3 tasks
clebs
clebs previously requested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@clebs clebs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not need a flag. The CLI is capable of detecting if a cluster is k3d.
Please see:

cli/internal/clusterinfo/k3d.go

Line 17 in 7a600e8

func isK3dCluster(ctx context.Context, kubeClient kubernetes.Interface) (isK3d bool, err error) {

@barchw barchw changed the title Add param for deploying on k3d Add default values for istio cni deployment on k3d Sep 23, 2022
@barchw barchw dismissed clebs’s stale review September 23, 2022 12:39

The proposed changes were introduced

@barchw
Copy link
Contributor Author

barchw commented Sep 23, 2022

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@barchw barchw changed the title Add default values for istio cni deployment on k3d Add value for istio specifying k3d as deployment Sep 23, 2022
@barchw barchw removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2022
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 26, 2022
@kyma-bot kyma-bot merged commit ee4a430 into kyma-project:main Sep 26, 2022
@barchw barchw deleted the k3d-param branch September 26, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clebs clebs clebs approved these changes

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@tobiscr tobiscr Awaiting requested review from tobiscr

@fourthisle fourthisle Awaiting requested review from fourthisle

@ruanxin ruanxin Awaiting requested review from ruanxin

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

@adityabhatia adityabhatia Awaiting requested review from adityabhatia

@a-thaler a-thaler Awaiting requested review from a-thaler

@lilitgh lilitgh Awaiting requested review from lilitgh

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@skhalash skhalash Awaiting requested review from skhalash

@chrkl chrkl Awaiting requested review from chrkl

@lindnerby lindnerby Awaiting requested review from lindnerby

@dennis-ge dennis-ge Awaiting requested review from dennis-ge

Assignees

@clebs clebs

Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barchw @clebs @kyma-bot