Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user/password credentials work for gcloud registry #1345

Merged

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP commented Aug 17, 2022

Description

Fixes: #1342
Changes proposed in this pull request:

  • Used a different authorizer that uses username/password combination to authorize push operations to the registry
  • Usage: Just provide the flag: --credentials user:password without any additional encoding. The username in gcloud case is always oauth2accesstoken and the password is the short-lived gcloud token (1 hour)

Related issue(s)
#1342

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2022
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP added area/cli Related to all activities around CLI and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 17, 2022
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 17, 2022
@Tomasz-Smelcerz-SAP
Copy link
Member Author

/test pre-cli-integration-kyma-2

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 17, 2022
@kyma-bot kyma-bot merged commit d05ce0f into kyma-project:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create module command not work with GCP artifacts registry
3 participants