Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layering engine for kyma modules #1322

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

clebs
Copy link
Contributor

@clebs clebs commented Jul 26, 2022

Description

Changes proposed in this pull request:

  • Module root folders are now inspected and specific subfolders and files are added into dedicated layers

Related issue(s)
#1317

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2022
@clebs
Copy link
Contributor Author

clebs commented Jul 26, 2022

/retest

1 similar comment
@clebs
Copy link
Contributor Author

clebs commented Jul 26, 2022

/retest

@clebs clebs added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2022
@adityabhatia adityabhatia linked an issue Jul 27, 2022 that may be closed by this pull request
@clebs clebs removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2022
@adityabhatia adityabhatia self-assigned this Jul 28, 2022
veichtj and others added 2 commits August 1, 2022 17:04
Module root folders are now inspected and specific subfolders and files are added into dedicated layers

Signed-off-by: Borja Clemente <borja.clemente.castanera@sap.com>
Charts now live in their own subflder and inspection needs to be adapted.

Signed-off-by: Borja Clemente <borja.clemente.castanera@sap.com>
Copy link
Contributor

@adityabhatia adityabhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🔥

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 3, 2022
@clebs clebs added the area/cli Related to all activities around CLI label Aug 3, 2022
@kyma-bot kyma-bot merged commit 2dd54fa into kyma-project:main Aug 3, 2022
@clebs clebs deleted the layer-engine branch August 3, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to all activities around CLI lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create module: layering engine
4 participants