Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm directory to dependabot updates #7657

Closed
lahabana opened this issue Sep 6, 2023 · 6 comments · Fixed by #12301
Closed

Add helm directory to dependabot updates #7657

lahabana opened this issue Sep 6, 2023 · 6 comments · Fixed by #12301
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

lahabana commented Sep 6, 2023

Description

We depend on a few 3rd party images (.e.g: #7656).

Dependabot supports updating versions in helm charts. It would be good to make sure this works for us.

A few things to check:

  1. Do dependabot work with docker images in values.yaml.
  2. If 1 is no what can we do?
@lahabana lahabana added area/ci-cd triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 6, 2023
@slonka
Copy link
Contributor

slonka commented Sep 11, 2023

according to dependabot/dependabot-core#5738 - it should work with

foo:
  image:
    repository: sql/sql
    tag: 1.2.3
    registry: docker.io

or alternatively:

foo:
  image:
    repository: sql/sql
    version: 1.2.3

Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Dec 11, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 11, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Mar 12, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 11, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lobkovilya lobkovilya removed the triage/stale Inactive for some time. It will be triaged again label Jun 17, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Sep 16, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 17, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Dec 17, 2024
michaelbeaumont added a commit that referenced this issue Dec 17, 2024
## Motivation

Closes #7657

## Implementation information

Switch to `directories` and search recursively for any charts.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci-cd kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants