Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review which kubectl image to use in Helm hooks #6326

Closed
lahabana opened this issue Mar 21, 2023 · 3 comments · Fixed by #7656
Closed

Review which kubectl image to use in Helm hooks #6326

lahabana opened this issue Mar 21, 2023 · 3 comments · Fixed by #7656
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lahabana
Copy link
Contributor

Description

If we still need them can we use an already existing kubectl image instead of building one. If yes let's remove tools/kubectl
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Mar 21, 2023
@jakubdyszkiewicz jakubdyszkiewicz changed the title review if we need hooks in helm Review which kubectl image to use in Helm hooks Apr 3, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Apr 3, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jul 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lobkovilya lobkovilya added triage/pending This issue will be looked at on the next triage meeting and removed triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again labels Jul 4, 2023
@michaelbeaumont
Copy link
Contributor

We have two separate, custom images for kubectl and kumactl. Let's remove kubectl!

@michaelbeaumont michaelbeaumont added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 10, 2023
lahabana added a commit to lahabana/kuma that referenced this issue Sep 6, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
c9681d7 
Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana mentioned this issue Sep 6, 2023
Merged
6 tasks
lahabana added a commit to lahabana/kuma that referenced this issue Sep 6, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
abb2bc8 
Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana
Copy link
Contributor Author

lahabana commented Sep 6, 2023 •
edited
Loading

@slonka mentionned gr.dev/chainguard/kubectl:latest as the best option but this is shown as experimental: https://github.com/chainguard-images/images/tree/main/images and there's no public version that is not the latest tag. So fell back to bitnami even if it's less nice (bitnami kubectl is the most popular kubectl image I believe).

lahabana added a commit to lahabana/kuma that referenced this issue Sep 6, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
fd23817 
Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit to lahabana/kuma that referenced this issue Sep 11, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
3c6d644 
also remove tools/kubectl

Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit to lahabana/kuma that referenced this issue Sep 12, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
fe80cf8 
also remove tools/kubectl

Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit to lahabana/kuma that referenced this issue Sep 12, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks
e69073d 
also remove tools/kubectl

Fix kumahq#6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit that referenced this issue Sep 12, 2023
@lahabana
fix(install): use bitnami/kubectl image for helm hooks (#7656)
ace9c13 
also remove tools/kubectl

Fix #6326

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(helm): use bitnami/kubectl image for helm hooks lahabana/kuma
4 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz @lobkovilya