Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binaries: Only stop the kubelet service if it's active #7568

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #7567

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@tstromberg tstromberg changed the title Only call stop on the kubelet if it's running binaries: Only Stop the kubelet service if it's active Apr 10, 2020
@tstromberg tstromberg changed the title binaries: Only Stop the kubelet service if it's active binaries: Only stop the kubelet service if it's active Apr 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #7568 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7568   +/-   ##
=======================================
  Coverage   36.49%   36.49%           
=======================================
  Files         147      147           
  Lines        9109     9109           
=======================================
  Hits         3324     3324           
  Misses       5398     5398           
  Partials      387      387           
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/bsutil/binaries.go 5.00% <0.00%> (ø)

@medyagh
Copy link
Member

medyagh commented Apr 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 10, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@medyagh
Copy link
Member

medyagh commented Apr 10, 2020

the issue that PR is trying to solve made me think, are we tranferring the binaries when preload is not available and the container run-time is containerd ?

$ make && ./out/minikube start --container-runtime=containerd --docker-opt containerd=/var/run/containerd/containerd.sock --apiserver-port=8444 --driver=docker  --kubernetes-version=v1.18.0
go build  -tags "container_image_ostree_stub containers_image_openpgp go_getter_nos3 go_getter_nogcs" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.9.2 -X k8s.io/minikube/pkg/version.isoVersion=v1.9.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="ded8273a2eadd3aa562177e52373cbfe725eb9d9-dirty"" -o out/minikube k8s.io/minikube/cmd/minikube

😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (2 available), Memory=4000MB (7964MB available) ...
📦  Preparing Kubernetes v1.18.0 on containerd 1.3.2 ...
    ▪ opt containerd=/var/run/containerd/containerd.sock
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
E0409 20:18:31.307780   43209 binaries.go:65] unable to stop kubelet: sudo systemctl stop -f kubelet: exit status 5
stdout:

stderr:
Failed to stop kubelet.service: Unit kubelet.service not loaded.
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

@tstromberg tstromberg merged commit 6449039 into kubernetes:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stderr spam: unable to stop kubelet: Unit kubelet.service not loaded.
5 participants