Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site: add hot tips for pushing images #7547

Merged
merged 3 commits into from
Apr 10, 2020
Merged

site: add hot tips for pushing images #7547

merged 3 commits into from
Apr 10, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 9, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2020
@medyagh medyagh changed the title improve wording on the docker push site site: improve wording on the docker push site Apr 9, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2020
@medyagh medyagh changed the title site: improve wording on the docker push site site: add hot tips to site for pushing images Apr 9, 2020
@medyagh medyagh changed the title site: add hot tips to site for pushing images site: add hot tips for pushing images Apr 9, 2020
@tstromberg
Copy link
Contributor

I like the concept, but can you move the Docker tips into a single sub-heading or info box?

Having 3 orange rectangles is jarring.

Also, please put a space after "Tip".

@medyagh
Copy link
Member Author

medyagh commented Apr 9, 2020

I like the concept, but can you move the Docker tips into a single sub-heading or info box?

Having 3 orange rectangles is jarring.

Also, please put a space after "Tip".

do u know the theme's keyword for info box or sub heading ?
I like it to look like an indented box but I agree the color is too much !

@medyagh medyagh merged commit 4b3f1e5 into kubernetes:master Apr 10, 2020
@medyagh medyagh deleted the docs_push_img_typos branch May 2, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@medyagh @k8s-ci-robot @tstromberg