Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conformance tag for internet connectivity #53381

Conversation

dims
Copy link
Member

@dims dims commented Oct 3, 2017

What this PR does / why we need it:

ICMP ping is not available in many environments, so we should avoid
using a e2e test based the premise as a conformance test.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
Part of Fix for #52098, Please see #51287 for more discussion

Release note:

NONE

ICMP ping is not available in many environments, so we should avoid
using a e2e test based the premise as a conformance test.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2017
@dims
Copy link
Member Author

dims commented Oct 3, 2017

cc @bgrant0607 @liggitt

@bgrant0607
Copy link
Member

Thanks.

This is necessary until we find a better solution.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, dims

Associated issue: 52098

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 3bb0f42 into kubernetes:master Oct 3, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 5, 2017
…pstream-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #53381

Cherry pick of #53381 on release-1.8.

#53381: Remove conformance tag for internet connectivity
@pires
Copy link
Contributor

pires commented Oct 9, 2017

Actually, I think some people may want to run air-gapped Kubernetes clusters that run without any access to the Internet so it makes sense to me to permanently remove this from conformance tests.

@kevin-wangzefeng
Copy link
Member

I think we also need to cherry pick this to 1.7.

@mjura
Copy link

mjura commented Oct 24, 2017

@dims, @bgrant0607: can we backport this patch to 1.7 branch, please? we hit also this same issue

@dims
Copy link
Member Author

dims commented Oct 24, 2017

@mjura @kevin-wangzefeng @bgrant0607 - Done!

k8s-github-robot pushed a commit that referenced this pull request Oct 24, 2017
…pstream-release-1.7

Automatic merge from submit-queue.

Automated cherry pick of #53381

Cherry pick of #53381 on release-1.7.

#53381: Remove conformance tag for internet connectivity
@dims dims deleted the remove-conformance-for-internet-connection-e2e-test branch November 16, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants