Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cut release-1.9.7 #1150

Merged
merged 2 commits into from
May 28, 2020
Merged

*: cut release-1.9.7 #1150

merged 2 commits into from
May 28, 2020

Conversation

tariq1890
Copy link
Contributor

Contains the following fix:

switch mutatingwebhookconfiguration to v1

(cherry picked from commit 59e0e0c)

tariq1890 added 2 commits May 24, 2020 10:41
(cherry picked from commit 59e0e0c)

# Conflicts:
#	internal/store/builder.go
@tariq1890 tariq1890 requested a review from lilic May 24, 2020 17:46
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 24, 2020
@k8s-ci-robot k8s-ci-robot requested a review from zouyee May 24, 2020 17:46
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2020
@brancz
Copy link
Member

brancz commented May 25, 2020

/lgtm
/hold

Feel free to remove hold when you're ready to proceed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tariq1890
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit b3fa585 into release-1.9 May 28, 2020
@mrueg mrueg deleted the pick-mwc-fix branch December 11, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants