Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote v1.8.8 CPA images. #5086

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Promote v1.8.8 CPA images. #5086

merged 1 commit into from
Apr 21, 2023

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Apr 5, 2023 •
edited
Loading

Note that the version tag now comes with a prefix v to be consistent with the versioning of other components (e.g. CPVA).

Ref kubernetes-sigs/cluster-proportional-autoscaler#138.

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 5, 2023
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin April 5, 2023 20:36
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Apr 5, 2023
@MrHohn MrHohn mentioned this pull request Apr 5, 2023
Closed
@k8s-ci-robot k8s-ci-robot added area/registry.k8s.io Code in registry.k8s.io/ and removed do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. labels Apr 5, 2023
@MrFreezeex MrFreezeex mentioned this pull request Apr 17, 2023
Merged
@MrHohn
Copy link
Member Author

MrHohn commented Apr 18, 2023

I know folks are busy with kubecon these weeks. Adding assignees in case that brings better visibility.
/assign @thockin @bowei

thockin
thockin reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e9d9257 into kubernetes:main Apr 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 21, 2023
This was referenced May 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@bowei bowei Awaiting requested review from bowei

Assignees

@bowei bowei

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@MrHohn @k8s-ci-robot @thockin @bowei