-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revendor against tip of k8s.io/kubernetes to prepare for 1.16 release of CA #2305
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzysztof-jastrzebski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dca8662
to
5b00111
Compare
I would prefer to have it merged first. We need revendoring for sake of building release for k8s 1.16 which is in freeze already. IMO introducing new process just before cutting new release adds unnecessary risk. #2286 should be easy to rebase just bu rerunning script you prepared there. Right? |
The rebase won't be simple, because my PR also moves the digitalocean cloudprovider out into /vendor, and this change modifies that and other dependencies. The risk should be really minimal, as re-running my change against the previous k8s commit (relative to this PR) resulted in no changes |
There seems to be an issue with |
…6.0-beta.2 (708a7f76dba706ed1e7dc4b4c3a53f63b0b7544a)
5b00111
to
7ad5bc0
Compare
Updated this PR to include bumping |
/lgtm |
This requirement was introduced by kubernetes/autoscaler#2305 and fixed for e.g aws here kubernetes/autoscaler#2404
Note: This pr uses old version of revendoring. The process will change slightly with #2286 merged