-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for view and admin cluster role #845
Conversation
Adding simple tests to verify the new aggregation roles are applied
Hi @anapsix. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! The cluster roles don't need to be duplicated for e2e but rather we want to validate the file in manifest_staging
. You can add the deploy commands here:
secrets-store-csi-driver/Makefile
Lines 403 to 408 in d32ca72
kubectl apply -f manifest_staging/deploy/csidriver.yaml | |
kubectl apply -f manifest_staging/deploy/rbac-secretproviderclass.yaml | |
kubectl apply -f manifest_staging/deploy/rbac-secretproviderrotation.yaml | |
kubectl apply -f manifest_staging/deploy/rbac-secretprovidersyncing.yaml | |
kubectl apply -f manifest_staging/deploy/secrets-store.csi.x-k8s.io_secretproviderclasses.yaml | |
kubectl apply -f manifest_staging/deploy/secrets-store.csi.x-k8s.io_secretproviderclasspodstatuses.yaml |
/retitle test: add test for view and admin cluster role |
Thanks @aramase, done! |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should I the same tests to the |
No, just |
/test pull-secrets-store-csi-driver-e2e-windows |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anapsix, tam7t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a follow-up to #836, adding simple tests to verify the new
aggregation roles are applied