Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix k/k path" #13

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

upodroid
Copy link
Member

Reverts #10

I forgot I can specify a path_alias in the prowjob :(

# this was removed from the codebase but the repo references old version that can't be resolved properly on the system.
maha4472@knative-e2e:~/provider-aws-test-infra$ grep -r KubeletCredentialProviders .
./vendor/k8s.io/kubernetes/test/e2e_node/remote/node_e2e.go:	featureGateFlag := "--kubelet-flags=--feature-gates=DisableKubeletCloudCredentialProviders=true,KubeletCredentialProviders=true"
./vendor/k8s.io/kubernetes/pkg/features/kube_features.go:	KubeletCredentialProviders featuregate.Feature = "KubeletCredentialProviders"
./vendor/k8s.io/kubernetes/pkg/features/kube_features.go:	KubeletCredentialProviders: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28
REDACTED@knative-e2e:~/go/src/sigs.k8s.io/provider-aws-test-infra$ go mod tidy
sigs.k8s.io/provider-aws-test-infra/test/e2e_node/remote/aws imports
	k8s.io/kubernetes/test/e2e_node/remote: k8s.io/kubernetes@v0.0.0: replacement directory ../../k8s.io/kubernetes does not exist
sigs.k8s.io/provider-aws-test-infra/test/e2e_node/runner/remote imports
	k8s.io/kubernetes/test/e2e_node/system: k8s.io/kubernetes@v0.0.0: replacement directory ../../k8s.io/kubernetes does not exist
sigs.k8s.io/provider-aws-test-infra/test/e2e_node/remote/aws imports
	sigs.k8s.io/yaml imports
	gopkg.in/yaml.v2 tested by
	gopkg.in/yaml.v2.test imports
	gopkg.in/check.v1: k8s.io/api@v0.27.0 (replaced by ../../k8s.io/kubernetes/staging/src/k8s.io/api): reading ../../k8s.io/kubernetes/staging/src/k8s.io/api/go.mod: open /home/maha4472/go/src/k8s.io/kubernetes/staging/src/k8s.io/api/go.mod: no such file or directory
sigs.k8s.io/provider-aws-test-infra/test/e2e_node/remote/aws imports
	github.com/aws/aws-sdk-go/service/ec2 imports
	github.com/aws/aws-sdk-go/aws/awsutil imports
	github.com/jmespath/go-jmespath tested by
	github.com/jmespath/go-jmespath.test imports
	github.com/jmespath/go-jmespath/internal/testify/assert: k8s.io/api@v0.27.0 (replaced by ../../k8s.io/kubernetes/staging/src/k8s.io/api): reading ../../k8s.io/kubernetes/staging/src/k8s.io/api/go.mod: open /home/maha4472/go/src/k8s.io/kubernetes/staging/src/k8s.io/api/go.mod: no such file or directory

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 13, 2023
@dims
Copy link
Member

dims commented Jun 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 651734b into kubernetes-sigs:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants