Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add documentation for namespace transformer #4906

Merged
merged 1 commit into from
Dec 9, 2022
Merged

docs: Add documentation for namespace transformer #4906

merged 1 commit into from
Dec 9, 2022
+60 −0

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Dec 5, 2022 •
edited
Loading

Add a short description of the namespace transformer and example
usage to examples/transformerconfigs/README.md.

References: #629
Signed-off-by: Lars Kellogg-Stedman lars@oddbit.com

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @larsks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2022
@larsks larsks mentioned this pull request Dec 5, 2022
Closed
@larsks larsks force-pushed the docs/namespace-transformer branch 2 times, most recently from 59e1696 to 1f7c4a7 Compare December 5, 2022 00:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Dec 5, 2022
@natasha41575
Copy link
Contributor

/cc @koba1t

@k8s-ci-robot k8s-ci-robot requested a review from koba1t December 6, 2022 23:51
@koba1t
Copy link
Member

koba1t commented Dec 7, 2022

/assign koba1t

koba1t
koba1t requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@koba1t koba1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsks
Thanks for your contribution!
I've added a few comments about the appearance of this doc.
Please check there!

@larsks larsks force-pushed the docs/namespace-transformer branch from 1f7c4a7 to a200df1 Compare December 8, 2022 14:07
@larsks
Copy link
Contributor Author

larsks commented Dec 8, 2022

@koba1t thanks for the review! I think I've addressed all your requests.

@koba1t
Copy link
Member

koba1t commented Dec 9, 2022 •
edited
Loading

@larsks
Thanks for your fix!
I think it looks good!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
natasha41575
natasha41575 reviewed Dec 9, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally each transformer doc would be in its own separate folder, (like how images and crds have their own folders). That doesn't have to be in this PR, but would be a welcome change in a followup if you have the time.

@larsks
docs: Add documentation for namespace transformer
d5e1940 
Add a short description of the namespace transformer and example
usage to examples/transformerconfigs/README.md.

References: kubernetes-sigs#629
Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>
@larsks larsks force-pushed the docs/namespace-transformer branch from a200df1 to d5e1940 Compare December 9, 2022 19:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@natasha41575
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: larsks, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 55edae1 into kubernetes-sigs:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@koba1t koba1t koba1t requested changes

@KnVerey KnVerey Awaiting requested review from KnVerey

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

@koba1t koba1t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larsks @k8s-ci-robot @natasha41575 @koba1t