Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a file sys.FileSystem interface to kio.ignoreFilesMatcher #3994

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Add a file sys.FileSystem interface to kio.ignoreFilesMatcher #3994

merged 1 commit into from
Jun 17, 2021

Conversation

campoy
Copy link
Contributor

@campoy campoy commented Jun 14, 2021 •
edited
Loading

Updates #3873

This PR adds support for kio.ignoreFilesMatcher by adding a field of type fileSystemOrOnDisk which defaults to disk unless an alternative value has been given.

The fileSystemOrOnDisk type will be used also in kio.LocalPackageRead(Writ)er and has been defined in kyaml/kio instead of api/filesys as requested in #3986.

ALLOW_MODULE_SPAN

@k8s-ci-robot
Copy link
Contributor

@campoy: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @campoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 14, 2021
@natasha41575
Copy link
Contributor

natasha41575 commented Jun 14, 2021 •
edited
Loading

Feel free to continue with #3986, I actually think it's fine if it's defined in api/filesys based on your reasoning.

EDIT: I just approved #3986, after it's merged you can rebase this and use the file system abstraction you defined there.

@natasha41575
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2021
natasha41575
natasha41575 reviewed Jun 14, 2021
View reviewed changes
@natasha41575 natasha41575 requested review from KnVerey and monopole and removed request for justinsb June 14, 2021 20:08
@campoy campoy force-pushed the ignore-filesys branch 2 times, most recently from 1922139 to d1ad6a9 Compare June 14, 2021 20:41
@campoy
Copy link
Contributor Author

campoy commented Jun 14, 2021

Updated to use the filesys.FileSystemOrOnDisk type introduced with #3986

@campoy campoy force-pushed the ignore-filesys branch 2 times, most recently from 7c55078 to a0e5f3e Compare June 14, 2021 21:03
@natasha41575
Copy link
Contributor

natasha41575 commented Jun 14, 2021 •
edited
Loading

Please squash the commits when you are done making these go.mod/go.sum edits

@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 14, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@campoy campoy force-pushed the ignore-filesys branch 2 times, most recently from 6248e8b to fbc5650 Compare June 16, 2021 21:46
@campoy
Copy link
Contributor Author

campoy commented Jun 16, 2021

ALLOW_MODULE_SPAN

@campoy campoy force-pushed the ignore-filesys branch 3 times, most recently from b41f244 to 01ef75c Compare June 16, 2021 23:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 16, 2021
@campoy
Copy link
Contributor Author

campoy commented Jun 16, 2021

Ok, thanks @KnVerey for pointing out that my change shouldn't involve any go.mod updates!

Now that I removed the missing dependency on /api everything is working and ready for review, @natasha41575

natasha41575
natasha41575 reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

kyaml/kio/ignorefilesmatcher_test.go
@@ -10,6 +10,8 @@ import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Love the require package :)

@natasha41575
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: campoy, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 60038d4 into kubernetes-sigs:master Jun 17, 2021
@campoy campoy deleted the ignore-filesys branch June 17, 2021 00:49
@campoy campoy mentioned this pull request Apr 11, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@KnVerey KnVerey Awaiting requested review from KnVerey

@monopole monopole Awaiting requested review from monopole

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@campoy @k8s-ci-robot @natasha41575