-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cilium 1.13.1 #9914
feat: support cilium 1.13.1 #9914
Conversation
Cilium 1.13.1 changed how the cilium-cni binary gets placed in /opt/cni/bin, so that it takes place in an init container rather than in the main agent.
Welcome @wbh1! |
Hi @wbh1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbh1 Thank you for this 🥳
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, wbh1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice! |
Looks good thanks :D /lgtm |
Cilium 1.13.1 changed how the cilium-cni binary gets placed in /opt/cni/bin, so that it takes place in an init container rather than in the main agent.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Cilium 1.13.1 changed how the cilium-cni binary gets placed in /opt/cni/bin, so that it takes place in an init container rather than in the main agent (cilium/cilium#24075). Consequently, that new init container needs to be included in the daemonset we generate.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This is somewhat related to #9879. That PR bumps the default Cilium version to 1.13.0. If this template is not fixed, users who set their Cilium version to anything above 1.13.0 will encounter CNI failures.
Does this PR introduce a user-facing change?:
This should be supported without the user needing to think about it, so I'm omitting a release note, but please let me know if one should be added.