Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cri-o arm64 v1.26.0 wrong archive checksum #9872

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix cri-o arm64 v1.26.0 wrong archive checksum #9872

merged 1 commit into from
Mar 9, 2023

Conversation

panguicai008
Copy link
Contributor

@panguicai008 panguicai008 commented Mar 9, 2023 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:

#9732
this pr is ok

#9760
this issue comment download https://storage.googleapis.com/cri-o/artifacts/cri-o.amd64.v1.26.0.tar.gz" and sha256 is 79837d8b7af95547b92dbab105268dd6382ce2a7afbddad93cc168ab0ca766c8
i validate is no problem

# cat cri-o.amd64.v1.26.0.tar.gz.sha256sum
79837d8b7af95547b92dbab105268dd6382ce2a7afbddad93cc168ab0ca766c8  cri-o.amd64.v1.26.0.tar.gz

so https://github.com/kubernetes-sigs/kubespray/pull/9761/files modify cri-o arm64 checksum incorretly

Special notes for your reviewer:

# cat cri-o.arm64.v1.26.0.tar.gz.sha256sum
8605b166d00c674e6363ee2336600fa6c6730a6a724f03ab3b72a0d5f9efcd1d cri-o.arm64.v1.26.0.tar.gz
fix CRI-O amd64 v1.26.0 wrong archive checksum

@panguicai008
fix cri-o arm64 v1.26.0 wrong archive checksum
5b51491 
Signed-off-by: panguicai008 <guicai.pan@daocloud.io>
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from bozzo and jayonlau March 9, 2023 07:16
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @panguicai008. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
floryut
floryut approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panguicai008 Thank you 👍
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, panguicai008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@oomichi
Copy link
Contributor

oomichi commented Mar 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2d20f0c into kubernetes-sigs:master Mar 9, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@panguicai008 @nolimitkun
fix cri-o arm64 v1.26.0 wrong archive checksum (kubernetes-sigs#9872)
f0e46ff 
Signed-off-by: panguicai008 <guicai.pan@daocloud.io>
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@panguicai008 @pedromcpedro
fix cri-o arm64 v1.26.0 wrong archive checksum (kubernetes-sigs#9872)
472acb9 
Signed-off-by: panguicai008 <guicai.pan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@bozzo bozzo Awaiting requested review from bozzo

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panguicai008 @k8s-ci-robot @oomichi @floryut