Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop crun_bin_dir unused var #9845

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Drop crun_bin_dir unused var #9845

merged 1 commit into from
Mar 3, 2023

Conversation

electrocucaracha
Copy link
Contributor

@electrocucaracha electrocucaracha commented Mar 2, 2023 •
edited by floryut
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
This change fixes the CRI-O configuration for crun runtime class

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

crun_enabled: true

Does this PR introduce a user-facing change?:

Drop `crun_bin_dir` unused variable, now using only `bin_dir` var

@electrocucaracha
Drop crun_bin_dir unused var
84dcfaf 
crun_bin_dir was used to specify the destination of the crun binary during the
download process. This path must match with the value provided in the CRI-O
configuration file. So changing its value to bin_dir helps to mismatch errors.

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2023
@k8s-ci-robot k8s-ci-robot requested review from EppO and yankay March 2, 2023 01:24
@yankay
Copy link
Member

yankay commented Mar 2, 2023

HI @electrocucaracha
Thank you for the PR. And would you please give us more information about why need the change?

@electrocucaracha
Copy link
Contributor Author

electrocucaracha commented Mar 2, 2023 •
edited
Loading

HI @electrocucaracha Thank you for the PR. And would you please give us more information about why need the change?

Sure @yankay, #9374 changed the CRI-O configuration to use bin_dir var when crun_enabled is true. The default value of bin_dir is /usr/local/bin so this contrasts with the default value of crun_bin_dir which is /usr/bin/. This mismatch causes runtime issues. There is no reason to keep this extra var, so I consider removing that variable is the best approach.

@oomichi
Copy link
Contributor

oomichi commented Mar 2, 2023

HI @electrocucaracha Thank you for the PR. And would you please give us more information about why need the change?

Sure @yankay, #9374 changed the CRI-O configuration to use bin_dir var when crun_enabled is true. The default value of bin_dir is /usr/local/bin so this contrasts with the default value of crun_bin_dir which is /usr/bin/. This mismatch causes runtime issues. There is no reason to keep this extra var, so I consider removing that variable is the best approach.

Thank you for solving the issue @electrocucaracha
That seems reasonable for me as

kubespray/roles/container-engine/cri-o/defaults/main.yml

Line 61 in 7fec254

path: "{{ bin_dir }}/crun"

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: electrocucaracha, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@yankay
Copy link
Member

yankay commented Mar 3, 2023

Thanks @electrocucaracha
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 677b7ec into kubernetes-sigs:master Mar 3, 2023
@electrocucaracha electrocucaracha deleted the remove-crun_bin_dir branch March 3, 2023 03:18
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@electrocucaracha @HoKim98
Drop crun_bin_dir unused var (kubernetes-sigs#9845)
501e1ea 
crun_bin_dir was used to specify the destination of the crun binary during the
download process. This path must match with the value provided in the CRI-O
configuration file. So changing its value to bin_dir helps to mismatch errors.

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@electrocucaracha @HoKim98
Drop crun_bin_dir unused var (kubernetes-sigs#9845)
a56b55d 
crun_bin_dir was used to specify the destination of the crun binary during the
download process. This path must match with the value provided in the CRI-O
configuration file. So changing its value to bin_dir helps to mismatch errors.

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@electrocucaracha @nolimitkun
Drop crun_bin_dir unused var (kubernetes-sigs#9845)
27eac26 
crun_bin_dir was used to specify the destination of the crun binary during the
download process. This path must match with the value provided in the CRI-O
configuration file. So changing its value to bin_dir helps to mismatch errors.

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@electrocucaracha @pedromcpedro
Drop crun_bin_dir unused var (kubernetes-sigs#9845)
429f5f0 
crun_bin_dir was used to specify the destination of the crun binary during the
download process. This path must match with the value provided in the CRI-O
configuration file. So changing its value to bin_dir helps to mismatch errors.

Signed-off-by: Victor Morales <chipahuac@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EppO EppO Awaiting requested review from EppO

@yankay yankay Awaiting requested review from yankay

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@electrocucaracha @yankay @oomichi @k8s-ci-robot