Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ingress url not found issue #9789

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix ingress url not found issue #9789

merged 1 commit into from
Feb 14, 2023

Conversation

JaneLiuL
Copy link
Member

@JaneLiuL JaneLiuL commented Feb 13, 2023 •
edited by floryut
Loading

/kind bug

ingress url not found, fix the url

Does this PR introduce a user-facing change?:

Fix ingress url not found issue

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from bozzo and mzaian February 13, 2023 08:53
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2023
mzaian
mzaian approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JaneLiuL for this.

@mzaian
Copy link
Contributor

mzaian commented Feb 13, 2023

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@yankay
Copy link
Member

yankay commented Feb 14, 2023

Thanks @JaneLiuL
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaneLiuL, mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit f06de07 into kubernetes-sigs:master Feb 14, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@JaneLiuL @HoKim98
fix ingress url not found issue (kubernetes-sigs#9789)
8f55687
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@JaneLiuL @HoKim98
fix ingress url not found issue (kubernetes-sigs#9789)
823ebcf
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@JaneLiuL @nolimitkun
fix ingress url not found issue (kubernetes-sigs#9789)
50dce68
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@JaneLiuL @pedromcpedro
fix ingress url not found issue (kubernetes-sigs#9789)
05c69f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@bozzo bozzo Awaiting requested review from bozzo

Assignees

@mzaian mzaian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaneLiuL @mzaian @yankay @k8s-ci-robot