Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 1.16.x hook on test packet_centos7-weave-kubeadm-sep and upgrade weave to 2.6.2 #5907

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Apr 8, 2020

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Remove hook as weave is working, the only thing that was making it fail was #5910
/hold until 5910 is merged in master and rebased on this branch

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @floryut. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and holmsten April 8, 2020 09:38
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 8, 2020
@floryut floryut force-pushed the kube_weave_1-17 branch 2 times, most recently from 3bd3e00 to 84f20ef Compare April 8, 2020 13:59
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2020
@floryut floryut changed the title [WIP] Try and test fix packet_centos7-weave-kubeadm-sep [WIP] Remove 1.16.x hook on test packet_centos7-weave-kubeadm-sep and upgrade weave to 2.6.2 Apr 8, 2020
@floryut floryut changed the title [WIP] Remove 1.16.x hook on test packet_centos7-weave-kubeadm-sep and upgrade weave to 2.6.2 Remove 1.16.x hook on test packet_centos7-weave-kubeadm-sep and upgrade weave to 2.6.2 Apr 9, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 10, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 11, 2020

Thank you for tracking this down @floryut

/lgtm
/approve

@Miouge1 Miouge1 added this to the 2.13 milestone Apr 11, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 11, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 45874a2 into kubernetes-sigs:master Apr 11, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants