Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multus): loop_control template error when item is None #10347

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix(multus): loop_control template error when item is None #10347

merged 1 commit into from
Aug 10, 2023

Conversation

nicolas-goudry
Copy link
Contributor

@nicolas-goudry nicolas-goudry commented Aug 8, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR avoids the loop_control templating to fail when item is None, which happens when the run of upgrade-cluster.yml is limited with --limit (see the issue it fixes for further details).

Which issue(s) this PR fixes:

Fixes #9703

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Multus] Fix loop_control template error when item is None

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @nicolas-goudry. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2023
@yankay
Copy link
Member

yankay commented Aug 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2023
MrFreezeex
MrFreezeex approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :D!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@yankay
Copy link
Member

yankay commented Aug 10, 2023

Thanks @nicolas-goudry
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, nicolas-goudry, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2a7c9d2 into kubernetes-sigs:master Aug 10, 2023
@nicolas-goudry nicolas-goudry deleted the fix/multus-loop_control-error-on-single-node-upgrade branch August 10, 2023 12:51
@yankay yankay mentioned this pull request Aug 24, 2023
Closed
@ErikJiang ErikJiang mentioned this pull request Aug 24, 2023
Merged
@hadi2f244 hadi2f244 mentioned this pull request Oct 25, 2023
Closed
VannTen pushed a commit to VannTen/kubespray that referenced this pull request Dec 15, 2023
@nicolas-goudry @VannTen
fix(multus): loop_control template error when item is None (kubernete…
3dff0bc 
…s-sigs#10347)
@VannTen VannTen mentioned this pull request Dec 15, 2023
Merged
k8s-ci-robot pushed a commit that referenced this pull request Dec 18, 2023
@VannTen @nicolas-goudry
fix(multus): loop_control template error when item is None (#10347) (#…
336b323 
…10726)

Co-authored-by: Nicolas Goudry <nicolas-goudry@users.noreply.github.com>
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Dec 27, 2023
@VannTen @notCalle
fix(multus): loop_control template error when item is None (kubernete…
1616fc3 
…s-sigs#10347) (kubernetes-sigs#10726)

Co-authored-by: Nicolas Goudry <nicolas-goudry@users.noreply.github.com>
(cherry picked from commit 336b323)
@VannTen VannTen mentioned this pull request Feb 5, 2024
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@nicolas-goudry @pedromcpedro
fix(multus): loop_control template error when item is None (kubernete…
52a3915 
…s-sigs#10347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node-based upgrade fails with: "Failed to template loop_control.label: 'None' has no attribute 'item'"
4 participants
@nicolas-goudry @k8s-ci-robot @yankay @MrFreezeex