-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flatcar] add python dependency check for helm-apps #10192
[flatcar] add python dependency check for helm-apps #10192
Conversation
Welcome @palmeXx! |
Hi @palmeXx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hmmm indeed it does not, could you then make this flatcar specific? IMO installing system wide packages via pip is a rather bad idea but I am fine it it's only a workaround for flatcar and possibly other distros that doesn't package it. |
i'm with you... |
FYI the other PR has been merged so please rebase your commit and also squash them if necessary and make it obvious it's for flatcar in the first commit title/PR title (or distros where pyyaml is not packaged if you find any and willing to do that, which is fine if you don't). |
e593a2b
to
4c76feb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and all the change :D!
/lgtm
/ok-to-test
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrFreezeex, oomichi, palmeXx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…10192) * add pyyaml install via task instead of package * Change condition for better consistency in the codebase
…10192) * add pyyaml install via task instead of package * Change condition for better consistency in the codebase
What type of PR is this?
/kind bug
What this PR does / why we need it:
helm-apps require PyYAML https://docs.ansible.com/ansible/latest/collections/kubernetes/core/helm_module.html as a dependency on the node where the Helm binaries are executed. The setup process does not install PyYAML during the OS bootstrapping, which can cause helm apps to fail due to missing dependencies.
The problem was encountered when activating
kubelet_rotate_server_certificates
with Flatcar as the operating system and kubespray release v2.22.0.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: