-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coredns): coredns_rewrite_block to perform internal message rewriting #10045
Conversation
…iting Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
Hi @maxime1907. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxime1907 Thank you for the PR 🙇
/kind feature
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, maxime1907 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
To kick CI jobs again. |
…iting (kubernetes-sigs#10045) Signed-off-by: Maxime Leroy <19607336+maxime1907@users.noreply.github.com>
What type of PR is this?
What this PR does / why we need it:
Adds a variable
coredns_rewrite_block
so that we can perform internal message rewriting.It is really useful when we want for instance multiple internal domain names that resolve to
cluster.local
:Does this PR introduce a user-facing change?: