Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runc v1.1.7 checksums #10039

Merged
merged 3 commits into from
May 6, 2023
Merged

Add runc v1.1.7 checksums #10039

merged 3 commits into from
May 6, 2023

Conversation

pomland-94
Copy link
Contributor

@pomland-94 pomland-94 commented May 2, 2023 •
edited by floryut
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:
Added checksums for runc v1.1.7 to keep runc up to date

Which issue(s) this PR fixes:

Fixes #

  • Add Checksum for runc v1.1.7 (amd64, arm64, ppc64le)
    Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[runc] Upgrade to v1.1.7

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 2, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pomland-94 / name: Patrick (578a94d)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @pomland-94!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pomland-94. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 2, 2023
@pomland-94
Copy link
Contributor Author

Signed the CLA but already says "Missing CLA Auth"

floryut
floryut approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomland-94 Thank you 👍
Could you check the CLA for your commit email i***@patrick-omland.de ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, pomland-94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2023
@floryut floryut added kind/container-managers Containers section in the release note approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. labels May 2, 2023
@floryut
Copy link
Member

floryut commented May 2, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2023
@pomland-94
Copy link
Contributor Author

I'll check my email and the confirmation mail is there.

@pomland-94
Copy link
Contributor Author

/check-cla

@DerrickLFX
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 2, 2023
@mzaian
Copy link
Contributor

mzaian commented May 3, 2023

Hello @pomland-94

Thanks a lot how about adding the missing checksums for versions (v1.1.5, v1.1.6).

Hello @floryut
How many version(s) I can see we are retaining many versions?

@pomland-94
Copy link
Contributor Author

sure, i can do it when it is desired.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2023
@pomland-94
Copy link
Contributor Author

Add version v1.1.5 and 1.1.6

@yankay
Copy link
Member

yankay commented May 6, 2023

Thanks @@pomland-94
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 970ecbb into kubernetes-sigs:master May 6, 2023
@pomland-94 pomland-94 deleted the runc-1.1.7 branch May 6, 2023 05:47
@yankay yankay mentioned this pull request May 15, 2023
Closed
notCalle pushed a commit to ModioAB/kubespray that referenced this pull request Dec 27, 2023
@pomland-94 @notCalle
Add runc v1.1.7 checksums (kubernetes-sigs#10039)
5c383a7 
* Add runc v1.1.7 checksums

* Add runc v1.1.6 and v1.1.5 checksums

(cherry picked from commit 970ecbb)
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@pomland-94 @pedromcpedro
Add runc v1.1.7 checksums (kubernetes-sigs#10039)
9a8b941 
* Add runc v1.1.7 checksums

* Add runc v1.1.6 and v1.1.5 checksums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay left review comments

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/container-managers Containers section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pomland-94 @k8s-ci-robot @floryut @DerrickLFX @mzaian @yankay