-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coredns_additional_configs to handle any extra configurations for… #10025
Conversation
|
Welcome @navidnabavi! |
Hi @navidnabavi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
CI is not running properly! |
…ations for coredns deployment (kubernetes-sigs#10023)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@navidnabavi Thank you for the PR 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, navidnabavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @navidnabavi |
…ations for coredns deployment (kubernetes-sigs#10023) (kubernetes-sigs#10025)
What type of PR is this?
What this PR does / why we need it:
It adds the
coredns_additional_configuration
inventory variable to append defined configurations. It is useful when we need to add some configurations to the Corefile itself mostly when using external plugins of CoreDNS.Which issue(s) this PR fixes:
Fixes #10023
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Only if you use the new variable.