-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom prometheus metrics documentation #1045
Add custom prometheus metrics documentation #1045
Conversation
Welcome @geezyx! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, geezyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hello there!
I am a user of kubebuilder and recently was trying to figure out how to publish additional metrics from my controllers. I struggled to find documentation on how to achieve this, but did eventually figure it out from another PR (kubernetes-sigs/controller-runtime#132)
This PR adds a simple example of how one might add collectors and register them with the global registry.
I also updated
reference.md
which seemed to have some stale content.I'd be happy to adjust the example if someone has a better approach or more generic way of presenting the idea to users for documentation purposes.
I intentionally didn't add a lot of extra explanation to the doc, since the example is pretty straightforward. Let me know if you want more context or examples.