Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kustomize/kyaml/filesys #206

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

atoato88
Copy link
Contributor

@atoato88 atoato88 commented Mar 3, 2022

What this PR does / why we need it:
This PR replace kustomize/api/filesys with kustomize/kyaml/filesys because of kustomize/api/filesys is deprecated now.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
NONE

Additional documentation:
NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from droot and monopole March 3, 2022 05:15
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2022
@atoato88
Copy link
Contributor Author

/assign @justinsb

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
This commit replace `kustomize/api/filesys` with
`kustomize/kyaml/filesys` because of api/filesys is deprecated now.
@atoato88 atoato88 force-pushed the use-kyaml-filesys branch from 8acf0c9 to 9aece30 Compare March 15, 2022 01:12
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022
@justinsb
Copy link
Contributor

Thanks @atoato88 - I confirmed that api is currently forwarding to kyaml and that api is marked as deprecated.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a108b38 into kubernetes-sigs:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants