Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged temp dirs to simplify cleanup #504

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

corneliusweig
Copy link
Contributor

Fixes #...
Related issue: #...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2020

/tmp shouldn't really need cleanup? :D Isn't that OS responsibility?

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #504 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   58.51%   58.51%           
=======================================
  Files          22       22           
  Lines         969      969           
=======================================
  Hits          567      567           
  Misses        346      346           
  Partials       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 324f5ed...6429f96. Read the comment docs.

@corneliusweig
Copy link
Contributor Author

corneliusweig commented Feb 12, 2020

It is, but usually (at least on my system) it's only done on reboot. And I don't boot frequently O_o

This is not important, but a bit more comfortable.

@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2020

why don't you just add && rm -rf $KREW_ROOT to the script? that's much easier?

@corneliusweig
Copy link
Contributor Author

I think KREW_ROOT is not available anymore in the command after &&?

@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2020

eh, you're right.

@ahmetb
Copy link
Member

ahmetb commented Feb 12, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit fb5343a into kubernetes-sigs:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants