Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/installation: unused pluginVersionFromPath #290

Merged

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jul 22, 2019

Removing unused method.

Aside: It would be good to have a lint check that validates that unexposed
methods are not used (maybe even for external methods).

/kind cleanup
/assign @corneliusweig

Removing unused method.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 22, 2019
@k8s-ci-robot

This comment has been minimized.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 22, 2019
@corneliusweig
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2019
@k8s-ci-robot k8s-ci-robot merged commit 86a9199 into kubernetes-sigs:master Jul 22, 2019
@codecov-io
Copy link

codecov-io commented Jul 23, 2019

Codecov Report

Merging #290 into master will increase coverage by 1.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   54.84%   56.22%   +1.38%     
==========================================
  Files          19       19              
  Lines         877      891      +14     
==========================================
+ Hits          481      501      +20     
+ Misses        342      337       -5     
+ Partials       54       53       -1
Impacted Files Coverage Δ
pkg/installation/util.go 37.5% <ø> (-3.88%) ⬇️
pkg/index/platform.go
pkg/installation/platform.go 91.66% <0%> (ø)
pkg/index/validation/validate.go 93.65% <0%> (+2.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6b8c8...463d001. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants