Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: move out install_kubectl_if_needed #220

Merged
merged 1 commit into from
Jun 27, 2019
Merged

hack: move out install_kubectl_if_needed #220

merged 1 commit into from
Jun 27, 2019

Conversation

ahmetb
Copy link
Member

@ahmetb ahmetb commented Jun 19, 2019

  • install appropriate kubectl (goos/goarch)
  • save it to $GOPATH/bin since "export $PATH" won't work outside a particular
    script
  • lowercase naming for local variables

Fixes #210.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2019
@ahmetb
Copy link
Member Author

ahmetb commented Jun 19, 2019

/assign @corneliusweig

@k8s-ci-robot
Copy link
Contributor

@ahmetb: GitHub didn't allow me to assign the following users: corneliusweig.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @corneliusweig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

corneliusweig
corneliusweig suggested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@corneliusweig corneliusweig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but needs small adjustments.

@ahmetb
hack: move out install_kubectl_if_needed
6f2ed48 
- install appropriate kubectl (goos/goarch)
- save it to $GOPATH/bin since "export $PATH" won't work outside a particular
  script
- lowercase naming for local variables

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@ahmetb ahmetb force-pushed the kubectl-install branch from e643ab3 to 6f2ed48 Compare June 20, 2019 17:22
@codecov-io
Copy link

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   54.35%   54.35%           
=======================================
  Files          13       13           
  Lines         701      701           
=======================================
  Hits          381      381           
  Misses        269      269           
  Partials       51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6629aa...6f2ed48. Read the comment docs.

@ahmetb
Copy link
Member Author

ahmetb commented Jun 27, 2019

I'll go ahead and merge this since @corneliusweig approved.

@ahmetb ahmetb merged commit 041b053 into kubernetes-sigs:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusweig corneliusweig corneliusweig approved these changes

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hack/run-integration-tests.sh: move install_kubectl_if_needed out
4 participants
@ahmetb @k8s-ci-robot @codecov-io @corneliusweig