v0.15.1 AWS ListTagsForResource Member must have length less than or equal to 32

[nerdingas-armaitis]

What happened:
After upgrading external-dns from 0.15.0 to 0.15.1 it starts failing to refresh zones list cache

error:

time="2025-01-17T11:20:58Z" level=debug msg="Refreshing zones list cache"
time="2025-01-17T11:20:58Z" level=error msg="Failed to do run once: soft error\nrecords retrieval failed: soft error\nfailed to list zones tags: soft error\nfailed to list tags for zone /hostedzone/Z12345678901234567890: operation error Route 53: ListTagsForResource, https response error StatusCode: 400, RequestID: a4d4c7e0-488e-4c30-8a10-c1be7107e757, InvalidInput: 1 validation error detected: Value '/hostedzone/Z12345678901234567890' at 'resourceId' failed to satisfy constraint: Member must have length less than or equal to 32"

What you expected to happen:
external-dns to keep working

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• External-DNS version (use external-dns --version): 0.15.1
• DNS provider: AWS R53
• Others:

        args:
        - --source=ingress
        - --domain-filter=xxx
        - --provider=aws
        - --registry=txt
        - --aws-zone-type=private
        - --aws-zone-tags=xxx
        - --txt-owner-id=xxx
        - --log-level=debug
        - --annotation-filter=kubernetes.io/external-dns-class in (xxx, yyy)

[ivankatliarchuk]

/assign

[ivankatliarchuk]

Ok. Most likely found an isssue. Something I encounter with terraform while back as well.

The change introduced in this pull request cause an issue #4640

With AWS SDK for Go v1, Route53 API URLs were sanitized, removing the leading /hostedzone/ or /change/: https://github.com/aws/aws-sdk-go/blob/ae77b91ecc806411e9c3ebbeebbea036ed908a0d/service/route53/customizations.go#L27.

With AWS SDK for Go v2 it looks like ListTagsForResource and ChangeTagsForResource don't clean the API URL (see aws/aws-sdk-go-v2#1838).

[ivankatliarchuk]

/remove-help

[ivankatliarchuk]

staging image is available for testing from here https://console.cloud.google.com/gcr/images/k8s-staging-external-dns/GLOBAL/external-dns?pli=1&inv=1&invt=AboC3A