Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetChange broken in github.com/aws/aws-sdk-go-v2/service/route53 v1.21.11 #1838

Closed
mastermanu opened this issue Sep 9, 2022 · 3 comments · Fixed by #1852
Closed

GetChange broken in github.com/aws/aws-sdk-go-v2/service/route53 v1.21.11 #1838

mastermanu opened this issue Sep 9, 2022 · 3 comments · Fixed by #1852
Assignees
Labels
bug This issue is a bug.

Comments

@mastermanu
Copy link

Describe the bug

  1. a.route53Client.ChangeResourceRecordSets returns a change ID with the "/change/" prefix.
  2. Pass the changeID as received to a.route53Client.GetChange()
  3. Get the following error:
operation error Route 53: GetChange, https response error StatusCode: 404, RequestID: e79ad9fd-e288-44ff-bfa3-47f6b7b968fc, NoSuchChange: Could not find resource with ID: /change/C003789825HUY95U5CD79"

Change ID does exist:

aws --profile test-dns route53 get-change --id /change/C003789825HUY95U5CD79
{
    "ChangeInfo": {
        "Id": "/change/C003789825HUY95U5CD79",
        "Status": "INSYNC",
        "SubmittedAt": "2022-09-09T19:00:56.449000+00:00"
    }
}

Expected Behavior

This worked in 1.20.4. It broke in 1.21.11

Current Behavior

See bug description. User has to workaround this by manually trimming "/change/" prefix on changeID before passing it to GetChange(), which is not ideal.

Reproduction Steps

See bug description. Looks very similar to something reported on the rust SDK: awslabs/aws-sdk-rust#554. Something clearly regressed.

Possible Solution

No response

Additional Information/Context

No response

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go v1.44.94
github.com/aws/aws-sdk-go-v2 v1.16.14
github.com/aws/aws-sdk-go-v2/config v1.17.5
github.com/aws/aws-sdk-go-v2/credentials v1.12.18
github.com/aws/aws-sdk-go-v2/service/autoscaling v1.23.14
github.com/aws/aws-sdk-go-v2/service/ec2 v1.54.4
github.com/aws/aws-sdk-go-v2/service/ecr v1.17.16
github.com/aws/aws-sdk-go-v2/service/eks v1.21.11
github.com/aws/aws-sdk-go-v2/service/route53 v1.21.11
github.com/aws/aws-sdk-go-v2/service/s3 v1.27.9
github.com/aws/aws-sdk-go-v2/service/sts v1.16.17

Compiler and Version used

go 1.18

Operating System and version

Ubuntu AMD64

@mastermanu mastermanu added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2022
@RanVaknin RanVaknin self-assigned this Sep 11, 2022
@RanVaknin RanVaknin added needs-review This issue or pull request needs review from a core team member. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 19, 2022
@RanVaknin
Copy link
Contributor

Issue confirmed. I've added an action item for us to try and cleanup the path.

Thank you!
Ran~

@RanVaknin RanVaknin added pending-release This issue will be fixed by an approved PR that hasn't been released yet. and removed needs-review This issue or pull request needs review from a core team member. labels Sep 20, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@RanVaknin RanVaknin removed the pending-release This issue will be fixed by an approved PR that hasn't been released yet. label Sep 21, 2022
@RanVaknin RanVaknin reopened this Sep 21, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants