✨ s/kubebuilder:validation:Default/kubebuilder:Default/ #337
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
marun
changed the title
droot
reviewed
Oct 7, 2019
pkg/crd/markers/validation.go
Outdated
| @@ -73,7 +73,7 @@ var FieldOnlyMarkers = []*definitionWithHelp{ | |||
| must(markers.MakeDefinition("nullable", markers.DescribesField, Nullable{})). | |||
| WithHelp(Nullable{}.Help()), | |||
|
|
|||
| must(markers.MakeAnyTypeDefinition("kubebuilder:validation:Default", markers.DescribesField, Default{})). | |||
| must(markers.MakeAnyTypeDefinition("kubebuilder:Default", markers.DescribesField, Default{})). | |||
There was a problem hiding this comment.
Had an offline chat with @DirectXMan12 about it. We should lowercase the Default to keep it consistent with kubebuilder:validation marker and eventually we can make these marker parsing case insensitive.
Otherwise, it looks good.
marun
force-pushed
the
fix-defaulting-tag
branch
from
d1c92bb to
4a548a7
Compare
|
/lgtm awesome |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DirectXMan12, marun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.