🐛Fix used scheme for fake client in List method #380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
List
method.Background
This bug #137 was already fixed by this PR: #213. Unfortunately in this PR the bug was reintroduced - probably by mistake.
NOTE:
I also tried to change the tests to never regress but such action will complicate the test suite, so IMO is really not worth to do that. But if you think that tests coverage should be added then let's decide which
types
should be used and how the test suite should look like, e.g. full tests forNewFakeClientWithScheme
and only one test forNewFakeClient
ensuring that it's injecting the"k8s.io/apimachinery/pkg/runtime/schema.Scheme"
? If the decision will be made then I can implement that too :)Related issue