Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update to Kubernetes 1.12.2 #221

Merged
merged 2 commits into from
Dec 1, 2018
Merged

✨ Update to Kubernetes 1.12.2 #221

merged 2 commits into from
Dec 1, 2018

Conversation

jimmidyson
Copy link
Member

Fixes #211

This has no breaking changes, only changes to dependencies and internal changes to work with the new version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2018
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 22, 2018
@jimmidyson
Copy link
Member Author

/assign @DirectXMan12

This was referenced Nov 22, 2018
Closed
Closed
@jimmidyson
Copy link
Member Author

Anyone able to review this? I'd really like to see it merged ASAP.

@DirectXMan12
Copy link
Contributor

I'll take a look -- last week was thanksgiving in the us, so I was out on break ;-)

@DirectXMan12
Copy link
Contributor

Furthermore, you've confirmed that there are no changes to the few objects from the Kubernetes API that we expose in public interfaces?

@jimmidyson
Copy link
Member Author

Hope Thanksgiving was a blast!

I'll verify tomorrow that there are no breaking changes to any interfaces this project exposes.

@jimmidyson
Copy link
Member Author

@DirectXMan12 As far as I can tell, it should be backwards-compatible, but tbh I'm not sure I've looked at every single thing... Do you have any pointers of things to double/triple check? The fact that tests didn't need to change (other than more known types) gives me confidence that stuff hasn't broken.

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 28, 2018 •
edited
Loading

I don't have anything at the moment. Let me try and whip something up. We only have a few objects though, and since it passes the tests, the changes are unlikely.

@jimmidyson
Copy link
Member Author

Any more thoughts on this?

@mengqiy
Copy link
Member

mengqiy commented Nov 30, 2018 •
edited
Loading

/lgtm
@jimmidyson Can you update it to the latest 1.12 which is 1.12.3 ? It should should not require much more work :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2018
@mengqiy
Copy link
Member

mengqiy commented Nov 30, 2018

/assign @droot
We need more eyeballs to catch any potential issues.

@DirectXMan12 DirectXMan12 changed the title Update to Kubernetes 1.12.2 ✨ Update to Kubernetes 1.12.2 Dec 1, 2018
@DirectXMan12
Copy link
Contributor

Finally finished enough of the tooling to run the check. We're good in this regard. I'll post the tooling soon, but I figured I'd give the results here and unblock this.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, jimmidyson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2018
@DirectXMan12
Copy link
Contributor

we can do the "latest patch release" in another PR if necessary.

@k8s-ci-robot k8s-ci-robot merged commit a405158 into kubernetes-sigs:master Dec 1, 2018
DirectXMan12
DirectXMan12 reviewed Dec 1, 2018
View reviewed changes
pkg/client/unstructured_client.go
@@ -142,7 +142,7 @@ func (uc *unstructuredClient) UpdateStatus(_ context.Context, obj runtime.Object
if err != nil {
return err
}
i, err := r.UpdateStatus(u)
i, err := r.UpdateStatus(u, metav1.UpdateOptions{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droot we'll want to surface create options somewhere in our client at some point

pkg/manager/internal.go
@@ -268,7 +268,7 @@ func (cm *controllerManager) startLeaderElection() (err error) {
RenewDeadline: 10 * time.Second,
RetryPeriod: 2 * time.Second,
Callbacks: leaderelection.LeaderCallbacks{
OnStartedLeading: func(_ <-chan struct{}) {
OnStartedLeading: func(_ context.Context) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll want to surface this too

@DirectXMan12
Copy link
Contributor

now we need to update controller-tools as well.

@jimmidyson jimmidyson mentioned this pull request Dec 2, 2018
Merged
justinsb pushed a commit to justinsb/controller-runtime that referenced this pull request Dec 7, 2018
@k8s-ci-robot
Merge pull request kubernetes-sigs#221 from jimmidyson/kubernetes-1.12
4443d36 
✨ Update to Kubernetes 1.12.2
@mengqiy mengqiy mentioned this pull request Dec 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 left review comments

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@DirectXMan12 DirectXMan12

@droot droot

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimmidyson @DirectXMan12 @mengqiy @k8s-ci-robot @droot