-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tolerate partial API discovery #36
Tolerate partial API discovery #36
Conversation
Welcome @rfranzke! |
/assign @MrHohn @ialidzhikov |
@rfranzke: GitHub didn't allow me to assign the following users: ialidzhikov. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is cleaner than I originally thought, LGTM with minor comments.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5754e13
to
260b752
Compare
Thanks! |
Great! Thanks for merging! It would be nice if you could release a new version with this fix :) |
Yep, will try to publish a new release this week. Opened #37 for that. |
Thank you @MrHohn! |
What type of PR is this?
/kind bug
What this PR does / why we need it:
The API discovery is now tolerating a partial discovery failure, e.g. caused due to unavailable API groups.
Which issue(s) this PR fixes:
Fixes #35
Special notes for your reviewer:
I added a unit test that simulates the behaviour and tested it successfully in a real-world scenario. If you like you can use
rfranzke/cpvpa-amd64:v0.8.2-1-g5754e13
Docker image for testing.Does this PR introduce a user-facing change?: