Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add machineClasses to default kustomization config list #606

Merged
merged 1 commit into from
Dec 10, 2018
Merged

Add machineClasses to default kustomization config list #606

merged 1 commit into from
Dec 10, 2018

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Nov 29, 2018

What this PR does / why we need it:
Add machineClasses to default kustomization config list

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @enxebre. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

roberthbailey
roberthbailey reviewed Nov 30, 2018
View reviewed changes
config/default/kustomization.yaml Outdated
@@ -22,6 +22,7 @@ resources:
- ../crds/cluster_v1alpha1_machine.yaml
- ../crds/cluster_v1alpha1_machinedeployment.yaml
- ../crds/cluster_v1alpha1_machineset.yaml
- ../crds/cluster_v1alpha1_machineclass.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look alphabetically sorted, in which case this should go above machinedeployment.yaml.

@roberthbailey
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2018
@roberthbailey
Copy link
Contributor

Ping @enxebre - it'd be nice to get this in before we cut a new build.

@enxebre enxebre force-pushed the kustomization-machineclasses branch from 9d83a16 to 0828e6a Compare December 7, 2018 10:08
@enxebre
Copy link
Member Author

enxebre commented Dec 7, 2018

Sorry @roberthbailey I'm travelling these days with no internet access most of the time. Updated.

@detiber
Copy link
Member

detiber commented Dec 7, 2018

/test pull-cluster-api-test

@detiber
Copy link
Member

detiber commented Dec 7, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
@roberthbailey
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2018
@k8s-ci-robot k8s-ci-robot merged commit 11daaa3 into kubernetes-sigs:master Dec 10, 2018
@enxebre enxebre mentioned this pull request Feb 5, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey left review comments

@jessicaochen jessicaochen Awaiting requested review from jessicaochen

@karan karan Awaiting requested review from karan

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enxebre @k8s-ci-robot @roberthbailey @detiber