Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8] 🌱 Attempt older version upgrades twice to work around flake with the docker controller #11794

Merged
merged 1 commit into from
Feb 4, 2025
Merged

[release-1.8] 🌱 Attempt older version upgrades twice to work around flake with the docker controller #11794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/e2e/clusterctl_upgrade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ var (
providerDockerPrefix = "docker:v%s"
)

var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.5=>current)", func() {
var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.5=>current)", FlakeAttempts(2), func() {
// We are testing v0.3=>v1.5=>current to ensure that old entries with v1alpha3 in managed files do not cause issues
// as described in https://github.com/kubernetes-sigs/cluster-api/issues/10051.
// NOTE: The combination of v0.3=>v1.5=>current allows us to verify this without being forced to upgrade
Expand Down Expand Up @@ -114,7 +114,7 @@ var _ = Describe("When testing clusterctl upgrades (v0.3=>v1.5=>current)", func(
})
})

var _ = Describe("When testing clusterctl upgrades (v0.4=>v1.6=>current)", func() {
var _ = Describe("When testing clusterctl upgrades (v0.4=>v1.6=>current)", FlakeAttempts(2), func() {
// We are testing v0.4=>v1.6=>current to ensure that old entries with v1alpha4 in managed files do not cause issues
// as described in https://github.com/kubernetes-sigs/cluster-api/issues/10051.
// NOTE: The combination of v0.4=>v1.6=>current allows us to verify this without being forced to upgrade
Expand Down