Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Refactor Cluster controller #11345

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR refactors the cluster controller introducing the same changes recently introduced in machine controller, machineset controller, md controller.
This will allow to add v1beta2 conditions in a follow-up PR

/area cluster

Which issue(s) this PR fixes:
Rif #11105

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/cluster cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR refactors the cluster controller introducing the same changes recently introduced in machine controller, machineset controller, md controller.
This will allow to add v1beta2 conditions in a follow-up PR

/area cluster

Which issue(s) this PR fixes:
Rif #11105

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 28, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 28, 2024
@fabriziopandini fabriziopandini added the area/provider/core Issues or PRs related to the core provider label Oct 28, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 28, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-blocking-main

@sbueringer
Copy link
Member

Thank you! Very nice!!

/lgtm
/approve

/hold
If you want to squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7f59eae320856594154f45bb798a26b4b18ef01

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2024
@fabriziopandini fabriziopandini force-pushed the refactor-cluster-controller branch from e31665c to 45446ee Compare October 31, 2024 15:17
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 31, 2024

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-main 66cf3d6 link true /test pull-cluster-api-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fabriziopandini
Copy link
Member Author

/retest

@fabriziopandini
Copy link
Member Author

/hold
Found some minor stuff to fix

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2024
@fabriziopandini
Copy link
Member Author

/hold cancel
The issue wasn't in the code included in this PR, but on some small changes I'm applying on top in a follow up PR implementing v1beta2 conditions

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1d1118f into kubernetes-sigs:main Nov 1, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 1, 2024
@fabriziopandini fabriziopandini deleted the refactor-cluster-controller branch November 13, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/core Issues or PRs related to the core provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants