-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Refactor Cluster controller #11345
🌱 Refactor Cluster controller #11345
Conversation
@fabriziopandini: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main |
/test pull-cluster-api-e2e-blocking-main |
Thank you! Very nice!! /lgtm /hold |
LGTM label has been added. Git tree hash: d7f59eae320856594154f45bb798a26b4b18ef01
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e31665c
to
45446ee
Compare
/hold cancel |
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
/hold |
/hold cancel |
What this PR does / why we need it:
This PR refactors the cluster controller introducing the same changes recently introduced in machine controller, machineset controller, md controller.
This will allow to add v1beta2 conditions in a follow-up PR
/area cluster
Which issue(s) this PR fixes:
Rif #11105